awslabs / dgl-ke

High performance, easy-to-use, and scalable package for learning large-scale knowledge graph embeddings.
https://dglke.dgl.ai/doc/
Apache License 2.0
1.28k stars 196 forks source link

Add data_files argument in dglke_client cmd for the custom dataset #210

Closed ryantd closed 3 years ago

ryantd commented 3 years ago

Issue #, if available:

Description of changes: args.data_files need to be passed into dist_train_test's get_dataset, which is invoked by dglke_client

https://github.com/awslabs/dgl-ke/blob/247ba99b4e288b3c43bacd2b00e4832b01c9a5c3/python/dglke/kvclient.py#L202

https://github.com/awslabs/dgl-ke/blob/247ba99b4e288b3c43bacd2b00e4832b01c9a5c3/python/dglke/train_pytorch.py#L285

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

classicsong commented 3 years ago

LGTM. Thanks for your contribution