search

awslabs / dgl-lifesci

Python package for graph neural networks in chemistry and biology
Apache License 2.0
696 stars 144 forks source link

Rename MoleculeCSVDataset to MoleculeDataFrameDataset #190

Open nbrosse opened 1 year ago

nbrosse commented 1 year ago

MoleculeCSVDataset takes as input a pandas DataFrame. It would be more appropriate to rename it MoleculeDataFrameDataset

https://github.com/awslabs/dgl-lifesci/blob/a6f45961ebef27eba3abbbc7c856418d9aa3de6f/python/dgllife/data/csv_dataset.py#L22

mufeili commented 1 year ago

While I agree this name can be misleading, directly renaming it might break too much backward compatibility. One possible workaround is to add an alias of the class MoleculeDFDataset.

nbrosse commented 1 year ago

Yep, good idea !