search

awslabs / dgl-lifesci

Python package for graph neural networks in chemistry and biology
Apache License 2.0
730 stars 151 forks source link

Do not downgrade scikit-learn requirement #198

Closed we-taper closed 2 years ago

we-taper commented 2 years ago

It seems weird to downgrade scikit-learn because python 3.6 is not supported . Could you relax this requirement?

Python 3.6 has been deprecated by pytorch, and for people who are still on 3.6, the pip installer will be able to find an older version of scikit-learn to install.

https://github.com/awslabs/dgl-lifesci/blob/91ef785bb5659108ade5d71ca88e0e89de16963a/python/setup.py#L41

mufeili commented 2 years ago

Addressed in https://github.com/awslabs/dgl-lifesci/pull/197

we-taper commented 2 years ago

Thanks! Haven't searched for it in the PRs. Happy to close this once the PR is merged.