search

awslabs / dynamodb-streams-kinesis-adapter

The Amazon DynamoDB Streams Adapter implements the Amazon Kinesis interface so that your application can use KCL to consume and process data from a DynamoDB stream.
Apache License 2.0
97 stars 37 forks source link

Build compatible with client-lib 1.7.3? #12

Closed tnixon closed 7 years ago

tnixon commented 7 years ago

Would it be possible to get a build of this project that is compatible with kinesis-client 1.73 (AWS SDK 1.11.76)?

I am working on integrating the DDB stream adapter into Spark so that spark streaming apps can read from a DDB stream. They are currently using SDK version 1.11.76 and kinesis-client 1.7.3 (I think mostly due to constraints of being compatible with Hadoop). The ddb-streams 1.1.1 build is compatible from 1.6.4 to 1.7.0 and the 1.2.0 build from 1.7.5 to 1.8.0, but no builds are compatible with 1.7.3. It would really help me out if there was a build available that was compatible in the 1.70-1.7.5 range.

Thanks!

tnixon commented 7 years ago

I'd be happy to get a compatible version in my fork and perhaps you could pull it in as a separate branch.

amcp commented 7 years ago

Please submit a pull request. FWIW, what is stopping you from dropping your own custom jars that support 1.7.3 in your fork? Is it as easy as just dropping the version range in pom.xml? Or is this change more complicated?

tnixon commented 7 years ago

I really hope it's not more complicated - it would be very nice if that's all I need to do :)

amcp commented 7 years ago

I coded support for 1.7.3 but you will have to build and consume it on your side.