search

awslabs / ec2-spot-labs

Collection of tools and code examples to demonstrate best practices in using Amazon EC2 Spot Instances.
https://aws.amazon.com/ec2/spot/
Other
935 stars 319 forks source link

Spinnaker blog #63

Closed black-mirror-1 closed 1 year ago

black-mirror-1 commented 1 year ago

Issue #, if available:

Description of changes: Resources related to blog post on new enhancements on the integration of EC2 Spot instances on Spinnaker.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

senkinnar commented 1 year ago

The instructions for spinnaker with ASG and Spot work fine. Please work on the comments below.

1\ The text needs to be reviewed 2\ Key needs to be deleted 'aws ec2 delete-key-pair --key-name ${EC2_KEYPAIR_NAME} ' 3\ Works with version 1.29.0 we need to check with 1.29.1 4\ Are we using price-capacity-optimized allocation strategy ? 4\ Sequencing and timing of deletion.

black-mirror-1 commented 1 year ago

The instructions for spinnaker with ASG and Spot work fine. Please work on the comments below.

1\ The text needs to be reviewed 2\ Key needs to be deleted 'aws ec2 delete-key-pair --key-name ${EC2_KEYPAIR_NAME} ' 3\ Works with version 1.29.0 we need to check with 1.29.1 4\ Are we using price-capacity-optimized allocation strategy ? 4\ Sequencing and timing of deletion.

Thanks for reviewing the PR @senkinnar. I have added instructions on the sequencing/timing of deletion and key deletion in the cleanup section.

Currently Spinnaker only supports capacity-optimized and lowest-price allocation strategies. I have submitted issue to enable the new price-capacity-optimized allocation strategy.

black-mirror-1 commented 1 year ago

@senkinnar the v1.29.1 is out. Can you validate the steps and approve the PR?