search

awslabs / ec2-spot-workshops

Collection of workshops to demonstrate best practices in using Amazon EC2 Spot Instances. https://aws.amazon.com/ec2/spot/
Other
181 stars 150 forks source link

Minor fixes on ECS Spot workshop #158

Closed black-mirror-1 closed 2 years ago

black-mirror-1 commented 2 years ago

Issue #, if available:

Description of changes:

  1. Removed the hard coded LaunchTeplateName and updated to use the LaunchTemplateId populated from stack outputs.
  2. Added an info about the need to update the Launch template if a different name for the cluster than EcsSpotWorkshop is used.
  3. Resizing the EBS volume fails for nitro instances. Added a reboot which will automatically grow the fs.
  4. Setting the Stack name before exporting the Cloudformation outputs is now in multiple tabs to avoid confusion.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ruecarlo commented 2 years ago

Changes have been accepted and and being merged as part of this other PR: https://github.com/awslabs/ec2-spot-workshops/pull/159