search

awslabs / eks-node-viewer

EKS Node Viewer
Apache License 2.0
1.2k stars 105 forks source link

bug: tool fails with Karpenter v1.0 and new APIs #315

Open mbevc1 opened 2 months ago

mbevc1 commented 2 months ago

Using latest Karpenter v1.0.1, the toll fails with:

0823 16:41:56.172646  107653 reflector.go:535] pkg/mod/k8s.io/client-go@v0.28.4/tools/cache/reflector.go:229: failed to list *v1beta1.NodeClaim: conversion webhook for karpenter.sh/v1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/conversion/karpenter.sh?timeout=30s": service "karpenter" not found
E0823 16:41:56.172703  107653 reflector.go:147] pkg/mod/k8s.io/client-go@v0.28.4/tools/cache/reflector.go:229: Failed to watch *v1beta1.NodeClaim: failed to list *v1beta1.NodeClaim: conversion webhook for karpenter.sh/v1, Kind=NodeClaim failed: Post "https://karpenter.kube-system.svc:8443/conversion/karpenter.sh?timeout=30s": service "karpenter" not found

We probably need to bump deps and APIs?

punkwalker commented 2 months ago

There are two parts to this issue.

First, eks-node-viewer still uses v1Beta1 Karpenter APIs, which should be fixed with #316.

Second, The v1 CRDs include a conversion webhook to convert resources from v1Beta1 to v1. It has to be in the same namespace as Karpenter deployment. Until the PR is merged there are two solutions:

  1. Make sure the CRDs are installed/upgraded as per step 5 in instructions here
  2. Manually update v1beta1 resources to v1 and only use v1 resources.
mbevc1 commented 2 months ago

To link you PR #316 bumping to v1 :wink:

mbevc1 commented 2 months ago

It was linked to #315 not #316 :wink: