awslabs / emr-dynamodb-connector

Implementations of open source Apache Hadoop/Hive interfaces which allow for ingesting data from Amazon DynamoDB
Apache License 2.0
216 stars 135 forks source link

handle deletes #173

Closed anmsf closed 1 year ago

anmsf commented 1 year ago

Issue 118

Description of changes: Properly handle delete requests when batching

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Build output:

[INFO] Building jar: /Volumes/work/code2/external/emr-dynamodb-connector/emr-dynamodb-tools/target/emr-dynamodb-tools-5.0.0-SNAPSHOT-tests.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for EMRDynamoDBConnector 5.0.0-SNAPSHOT:
[INFO] 
[INFO] EMRDynamoDBConnector ............................... SUCCESS [  0.400 s]
[INFO] EMRDynamoDBHadoop .................................. SUCCESS [02:03 min]
[INFO] EMRDynamoDBConnectorShims .......................... SUCCESS [  0.029 s]
[INFO] ShimsCommon ........................................ SUCCESS [  2.269 s]
[INFO] Hive2Shims ......................................... SUCCESS [  1.215 s]
[INFO] Hive3Shims ......................................... SUCCESS [  0.434 s]
[INFO] ShimsLoader ........................................ SUCCESS [  0.645 s]
[INFO] EMRDynamoDBHive .................................... SUCCESS [  7.060 s]
[INFO] EMRDynamoDBTools ................................... SUCCESS [  2.882 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:18 min
[INFO] Finished at: 2023-04-10T23:01:02-07:00
[INFO] ------------------------------------------------------------------------
mimaomao commented 1 year ago

Hi @anmsf, nice work! We'd like to review your change. However, we have merged a change which greatly conflicts this change on master branch recently. Could you rebase your change on the latest master? Thanks!

anmsf commented 1 year ago

@mimaomao updated, thanks!