awslabs / fargatecli

CLI for AWS Fargate
Apache License 2.0
893 stars 114 forks source link

Enable new regions (3 more). #59

Closed provtimofei closed 5 years ago

provtimofei commented 6 years ago

According to https://aws.amazon.com/about-aws/global-infrastructure/regional-product-services/ there are 4 regions where fargate is supported now: Northern Virginia | Ohio | Oregon | Ireland I made changes locally and everything works for me. I can share my changes - diff is attached. diff --git a/README.md b/README.md index 3ba3401..ab67bb1 100644 --- a/README.md +++ b/README.md @@ -13,8 +13,8 @@

Region

-By default, fargate uses us-east-1. Also available us-west-2, us-east-2, eu-west-1. -The CLI accepts a --region parameter for future use and +By default, fargate uses us-east-1 as this is the single region where AWS +Fargate is available. The CLI accepts a --region parameter for future use and will honor AWS_REGION and AWS_DEFAULT_REGION environment settings. Note that specifying a region where all required services aren't available will return an error. diff --git a/cmd/root.go b/cmd/root.go index bca26b2..994ed22 100644 --- a/cmd/root.go +++ b/cmd/root.go @@ -45,7 +45,7 @@ CPU (CPU Units) Memory (MiB) 4096 8192 through 30720 in 1GiB increments `)

-var validRegions = []string{"us-east-1", "us-west-2", "us-east-2", "eu-west-1"} +var validRegions = []string{"us-east-1"}

var ( clusterName string @@ -105,16 +105,12 @@ CloudWatch Logs, and Amazon Route 53 into an easy-to-use CLI.`, } }

rnzsgh commented 6 years ago

+1

sitase commented 6 years ago
danielbehrendt commented 6 years ago

+1 for eu-central-1

Melbit-haixingzhang commented 6 years ago

+1 for ap-southeast-2

mgajda commented 6 years ago

+1 Added patch with all currently supported #62.

gliptak commented 6 years ago

There are four PRs on this

https://github.com/jpignata/fargate/pull/54 https://github.com/jpignata/fargate/pull/55 https://github.com/jpignata/fargate/pull/61 https://github.com/jpignata/fargate/pull/62

mgajda commented 6 years ago

Counting each one as :+1: , you can see that the author has no time to maintain this software. Feel free to pull from https://github.com/mgajda/fargate.

jpignata commented 6 years ago

Thanks @mgajda for the ping via email. I haven't had a lot of time over the past few months to invest time into this project. Fully expect to turn my attention back to it, but don't want to be a blocker For folks relying on it, I'm happy to do one of either/both of granting a commit bit or two or putting a list of cool/notable/more loved forks in the README. What are your thoughts?

Thanks for your interest, participation, and patience!

mgajda commented 6 years ago

@jpignata I will review and triage outstanding issues, if you give me commit bit. Having two or three more maintainers would indeed make sure that there is some response even in vacation periods :-).

mgajda commented 5 years ago

@provtimofei Seems you can close this ticket yet.

sebastianfuss commented 5 years ago

Hi @jpignata, @mgajda

is it possible to make a new release?

Thanks a lot in advance! Sebastian.