search

awslabs / fargatecli

CLI for AWS Fargate
Apache License 2.0
893 stars 114 forks source link

Add all valid regions as of July 19th 2018... #62

Closed mgajda closed 6 years ago

mgajda commented 6 years ago

Just to make it work for all non-US people out of the box...

mgajda commented 6 years ago

Just update of #61, #59, #55, and #54.

tisba commented 6 years ago

Please keep in mind that there seems to be more changes required, as pointed out in https://github.com/jpignata/fargate/pull/54 (issues regarding security groups).

jpignata commented 6 years ago

Thanks, @tisba. I suppose we can handle that separately. It seems possible to me off the top of my head that default VPCs have some kind of behavior difference between US East (N. Virginia) and elsewhere, though I don't know of any off the top of my head.

tisba commented 6 years ago

I don't recall exactly what the issue was. The only solution I found back then was to provide an explicit security group.

¯_(ツ)_/¯

mgajda commented 6 years ago

Hi John, I implemented your suggestions:

mgajda commented 6 years ago

I had the same issue after I removed default security group (which is open to all) in order to tighten security.

On Tue, Sep 4, 2018 at 6:53 PM Sebastian Cohnen notifications@github.com wrote:

I don't recall exactly what the issue was. The only solution I found back then was to provide an explicit security group.

¯(ツ)/¯

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jpignata/fargate/pull/62#issuecomment-418440827, or mute the thread https://github.com/notifications/unsubscribe-auth/AAp12XZ3xORWD3LcMLUez1u5wEfp8M9qks5uXrAIgaJpZM4WNs1e .

tisba commented 5 years ago

Are you planning to make a new release, @jpignata?

pahud commented 5 years ago

please release 0.2.4 with this PR, thanks.