search

awslabs / fargatecli

CLI for AWS Fargate
Apache License 2.0
893 stars 114 forks source link

`fargate service env set` triggers a deploy #92

Open asavoy opened 5 years ago

asavoy commented 5 years ago

I found it a bit surprising that fargate service env set will trigger a deploy just like fargate service deploy. Reading the code, it is as intended: there's a call to UpdateServiceTaskDefinition which causes a deploy of the updated task def to occur.

I was trying update both the env vars and the image at the same time in one deployment, so the current interface doesn't really allow for that.

Perhaps the command docs should hint at this behavior?

Or perhaps move the feature to set env vars into fargate service deploy?

I thought about whether fargate service env set should create a new task def that would be deployable later, but I'm guessing it's currently this way to simplify the use of Fargate by hiding away the concept of task defs.

Thanks for your work on this CLI tool, I was able to get a container running in Fargate in minutes very easily.

jritsema commented 4 years ago

Just FYI that our fork can deploy an image, envvars, and secrets in a single deploy via a -f flag.

https://github.com/turnerlabs/fargate#fargate-service-deploy