awslabs / fargatecli

CLI for AWS Fargate
Apache License 2.0
894 stars 115 forks source link

service deploy deletes secrets array values #93

Closed nodesocket closed 5 years ago

nodesocket commented 5 years ago

We are using the valueFrom in environment variables in a ECS task definition, which in the raw json is secrets: [...].

When running:

 fargate --cluster "$ECS_CLUSTER_NAME" service deploy "$ECS_SERVICE_NAME" --image "$IMAGE"

It reverts the valueFrom secrets in the task definition, and sets "secrets": [], nulling out all defined secrets from parameter store.