search

awslabs / fhir-works-on-aws-persistence-ddb

A DynamoDB implementation of the FHIR Works on AWS framework, enabling users to complete CRUD operations on FHIR resources
Apache License 2.0
27 stars 22 forks source link

fix: fix update query for Subscriptions #142

Closed carvantes closed 2 years ago

carvantes commented 2 years ago

A previous change introduced a bug in the syntax of the query: https://github.com/awslabs/fhir-works-on-aws-persistence-ddb/pull/140

"errorMessage": "Invalid UpdateExpression: An expression attribute name used in the document path is not defined; attribute name: #subscriptionStatus",

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 2 years ago

Codecov Report

Merging #142 (a4a260f) into mainline (0313b08) will increase coverage by 0.42%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           mainline     #142      +/-   ##
============================================
+ Coverage     89.29%   89.72%   +0.42%     
============================================
  Files            26       26              
  Lines          1168     1168              
  Branches        194      194              
============================================
+ Hits           1043     1048       +5     
+ Misses          121      116       -5     
  Partials          4        4
Impacted Files Coverage Δ
src/dataServices/dynamoDbParamBuilder.ts 98.59% <100.00%> (+7.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0313b08...a4a260f. Read the comment docs.