search

awslabs / fhir-works-on-aws-persistence-ddb

A DynamoDB implementation of the FHIR Works on AWS framework, enabling users to complete CRUD operations on FHIR resources
Apache License 2.0
27 stars 22 forks source link

feat: add Batch Bundle support #144

Closed ssvegaraju closed 2 years ago

ssvegaraju commented 2 years ago

Issue #, if available:

Description of changes: Implemented the processBatch method. To test, I deployed to an AWS Account and made sure all of the different CRUD operations completed successfully.

As for testing, Two points remain that will be caught in a different PR with integration tests: Load testing (very large bundles) and api throttling. In addition, this PR is the first in a series of PRs: 1) Release this PR to npm 2) Update persistence package on the interface and release that to npm 3) Update the interface package on the routing package and release that to npm 4) Update the routing package on the interface package once again and release to npm, 5) Update the interface package on the deployment package.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 2 years ago

Codecov Report

Merging #144 (99e1b93) into mainline (37b84d6) will decrease coverage by 0.65%. The diff coverage is 79.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##           mainline     #144      +/-   ##
============================================
- Coverage     89.72%   89.06%   -0.66%     
============================================
  Files            26       26              
  Lines          1168     1253      +85     
  Branches        194      215      +21     
============================================
+ Hits           1048     1116      +68     
- Misses          116      133      +17     
  Partials          4        4
Impacted Files Coverage Δ
src/dataServices/dynamoDbBundleService.ts 81.95% <26.31%> (-3.76%) :arrow_down:
src/dataServices/dynamoDbBundleServiceHelper.ts 94.96% <92.95%> (-1.67%) :arrow_down:
src/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37b84d6...99e1b93. Read the comment docs.