awslabs / fhir-works-on-aws-persistence-ddb

A DynamoDB implementation of the FHIR Works on AWS framework, enabling users to complete CRUD operations on FHIR resources
Apache License 2.0
27 stars 22 forks source link

[WIP] fix: check whether vid is a number #160

Closed kcadette closed 1 year ago

kcadette commented 1 year ago

Issue #, if available:

Description of changes: Update http error code to BadRequest when incorrect input is used for version id. I deployed and tested this change in a development acct

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Merging #160 (d3fc5f9) into mainline (331c0a1) will decrease coverage by 0.05%. The diff coverage is 75.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/awslabs/fhir-works-on-aws-persistence-ddb/pull/160/graphs/tree.svg?width=650&height=150&src=pr&token=WPOLR8C1W7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://codecov.io/gh/awslabs/fhir-works-on-aws-persistence-ddb/pull/160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## mainline #160 +/- ## ============================================ - Coverage 89.29% 89.24% -0.06% ============================================ Files 26 26 Lines 1271 1274 +3 Branches 213 214 +1 ============================================ + Hits 1135 1137 +2 - Misses 133 134 +1 Partials 3 3 ``` | [Impacted Files](https://codecov.io/gh/awslabs/fhir-works-on-aws-persistence-ddb/pull/160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [src/dataServices/dynamoDbDataService.ts](https://codecov.io/gh/awslabs/fhir-works-on-aws-persistence-ddb/pull/160/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL2RhdGFTZXJ2aWNlcy9keW5hbW9EYkRhdGFTZXJ2aWNlLnRz) | `90.67% <75.00%> (-0.38%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/awslabs/fhir-works-on-aws-persistence-ddb/pull/160?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/awslabs/fhir-works-on-aws-persistence-ddb/pull/160?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs). Last update [331c0a1...d3fc5f9](https://codecov.io/gh/awslabs/fhir-works-on-aws-persistence-ddb/pull/160?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs).
sevu1 commented 1 year ago

Also might be a good candidate for unit test