search

awslabs / fhir-works-on-aws-routing

The routing implementation of the FHIR Works on AWS framework. Finding the correct component to handle the HTTP FHIR request
Apache License 2.0
31 stars 26 forks source link

[WIP] Add Fixes to Routing Package #192

Closed kcadette closed 1 year ago

kcadette commented 1 year ago

Issue #, if available:

Description of changes: Improve Error Handling. Including Bad Request and Method Not Allowed errors.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ssvegaraju commented 1 year ago

I think you may need to run yarn install after bumping the package version to get the checks to pass

kcadette commented 1 year ago

unfortunately, the latest version isn't an option when I run yarn install. Its also not updated on npm yet so there could be some lag there

codecov-commenter commented 1 year ago

Codecov Report

Merging #192 (d05fc82) into mainline (a03a050) will decrease coverage by 0.16%. The diff coverage is 0.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/awslabs/fhir-works-on-aws-routing/pull/192/graphs/tree.svg?width=650&height=150&src=pr&token=YMMEJ4K2T4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://codecov.io/gh/awslabs/fhir-works-on-aws-routing/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## mainline #192 +/- ## ============================================ - Coverage 75.90% 75.73% -0.17% ============================================ Files 47 47 Lines 1386 1389 +3 Branches 297 298 +1 ============================================ Hits 1052 1052 - Misses 334 337 +3 ``` | [Impacted Files](https://codecov.io/gh/awslabs/fhir-works-on-aws-routing/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [src/router/routes/errorHandling.ts](https://codecov.io/gh/awslabs/fhir-works-on-aws-routing/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c3JjL3JvdXRlci9yb3V0ZXMvZXJyb3JIYW5kbGluZy50cw==) | `14.89% <0.00%> (-1.02%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/awslabs/fhir-works-on-aws-routing/pull/192?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/awslabs/fhir-works-on-aws-routing/pull/192?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs). Last update [a03a050...d05fc82](https://codecov.io/gh/awslabs/fhir-works-on-aws-routing/pull/192?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs).