search

awslabs / flowgger

A fast data collector in Rust
BSD 2-Clause "Simplified" License
834 stars 55 forks source link

Update capnp to 0.10 #52

Closed Trojan295 closed 5 years ago

Trojan295 commented 5 years ago

Issue #, if available: part of #33

Description of changes: This PR updates the capnp library to 0.10. As a result the capnp schema was recompiled. I couldn't find a flag to tell the capnp compiler to put the sources in a specific package path (now it is crate::flowgger::capnp_record, in my PR it's under crate::capnp_record), so I moved the compiled schema to the crate root.

@jedisct1 , is there some way to change that, besides modifying the generated schema manually?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jedisct1 commented 5 years ago

There has to be a way, but off the top of my head, I don't know :)

Not a big deal.

kurojishi commented 5 years ago

Can i ask you to write some tests for this before merging it in? I don't know this module enough to say this work as intended without tests

Trojan295 commented 5 years ago

I'm gonna write the tests next week

Trojan295 commented 5 years ago

@kurojishi, I added some tests

vche commented 5 years ago

Thanks @Trojan295 ! Looks good to me