awslabs / git-remote-s3

Apache License 2.0
492 stars 9 forks source link

Duplicate ListObjectsV2 API calls inside list_refs method #8

Closed bored-engineer closed 3 weeks ago

bored-engineer commented 1 month ago

There appears to be a bug in the list_refs method where the NextContinuationToken is used to paginate through a list of returned objects from (potentially multiple) ListObjectsV2 calls, only to have those results thrown away and replaced with the results from a duplicate, non-paginated ListObjectsV2 API call: https://github.com/awslabs/git-remote-s3/blob/221bde4ea34226d9e9b1f28bab97ea074c6bae82/git_remote_s3/remote.py#L60-L62