search

awslabs / git-secrets

Prevents you from committing secrets and credentials into git repositories
Apache License 2.0
12.36k stars 1.17k forks source link

`say` command during install should be removed or made configurable by flag #230

Open guerreit opened 1 year ago

guerreit commented 1 year ago

say "$(tput setaf 2)✓$(tput sgr 0) Installed ${hook} hook to ${dest}"

micxer commented 1 year ago

Why is this in there anyway? Doesn't make much sense. An echo in that place makes way more sense.

kallenboone commented 1 year ago

At least make it fun with -v Trinoids or -v Bahh.

But more seriously, please make it optional or remove it.

Hacksore commented 1 year ago

Trying to get this merged. That's not a guarantee but just wanted to share that with those who are subscribed to this issue.

justinblough commented 1 year ago

My entire team is plagued by this and absolutely irritated as it is part of our install process for packages.

sorenisanerd commented 1 year ago

I have to assume that say doesn't to text-to-speech on whichever platform was used for development for this, otherwise why add terminal control characters that won't be echoed, but will be read aloud?

It's kinda weird, honestly.

I recommend adding a directory with a say executable in it that just calls echo, and then add that to your path before calling git secrets --install.

Rylon commented 9 months ago

I think this got fixed in this commit: https://github.com/awslabs/git-secrets/commit/65891e23f341f159098300999edcce5983cd3ad8 however I don't see a new release tag since 1.3.0 which is dated Feb 10th 2019.

Would it be possible for someone to cut a new release and update the Homebrew formulae for it please? https://github.com/Homebrew/homebrew-core/blob/9f15fa987cbed2d11971a365d33b140a3eba3c74/Formula/g/git-secrets.rb

@mtdowling I'm pinging you as the author listed in the README if you are able to help at all?

Thanks very much :)

alvincrespo commented 3 months ago

Still an issue. Here is to hoping we get a new tag soon 🤞