search

awslabs / gluonts

Probabilistic time series modeling in Python
https://ts.gluon.ai
Apache License 2.0
4.65k stars 755 forks source link

CI: chain requirements to ensure compatibility #3112

Closed Borda closed 9 months ago

Borda commented 10 months ago

Issue #, if available: atm, all install requirements are installed as stand-alone, which means if there is a version collision, pip does not care about it, and so for eventual version compatibility, a collision may not be discovered

Description of changes: just install all needed requirements for the particular job at once so pip sees all required packages and finds an intersection among all :flags:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

cc: @jaheba @kashif @lostella kind ling as it seems there are no revivers by default :chipmunk:

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

lostella commented 10 months ago

@Borda thanks! I guess let's wait for all checks to be green before coming back to this

Borda commented 10 months ago

Just needs rebasing

@lostella done; just curious why rebasing and not just merging the dev branch?

lostella commented 10 months ago

Just needs rebasing

@lostella done; just curious why rebasing and not just merging the dev branch?

whatever works :-) what I meant is to update the branch so that CI workflows run

Borda commented 10 months ago

If possible, I would suggest dropping scikit-garden as it has been a stale project since 2017, and there seems to be no such intention for updating at least to installable without problems, see https://github.com/scikit-garden/scikit-garden/issues/105#issuecomment-1923509842

kashif commented 10 months ago

we can also move the pytorch version to 2.x no?

Borda commented 10 months ago

we can also move the pytorch version to 2.x no?

probably but lets make it as separate PR :chicken:

lostella commented 10 months ago

If possible, I would suggest dropping scikit-garden as it has been a stale project since 2017, and there seems to be no such intention for updating at least to installable without problems, see scikit-garden/scikit-garden#105 (comment)

Yeah we should get rid of that