search

awslabs / gluonts

Probabilistic time series modeling in Python
https://ts.gluon.ai
Apache License 2.0
4.57k stars 749 forks source link

extend exception for invalid `offset_name` #3115

Closed Borda closed 8 months ago

Borda commented 8 months ago

Issue #, if available: it is quite hard to understand why the exception was raised when you do not see the values

Description of changes: extend the exception, which will help a user understand what went wrong...

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

cc: @jaheba, @lostella, @kashif, @rshyamsundar

kashif commented 8 months ago

lets fix the issue, which is i believe that pandas has deprecated some of the freq strings. Screenshot 2024-01-29 at 11 44 14 Screenshot 2024-01-29 at 11 46 01

Borda commented 8 months ago

lets fix the issue, which is i believe that pandas has deprecated some of the freq strings.

That is a good point; if you do not mind, I will split it into two PRs as these springs are used in multiple places, and this PR keeps focused on the exception enrichment... So, I would take the conversion of the string just after :)

Borda commented 8 months ago

@kashif, based on your reaction, if you are fine with keeping this PR simple, would you mind approving Ci and reviewing it? :)

kashif commented 8 months ago

I am not a maintainer so have no such power... but I believe they will review it

lostella commented 8 months ago

@Borda thanks for this! Just left a comment on improving the message, let me know what you think.

There’s a lot of red in the workflows, I’ll take a look and try to unblock PRs

Borda commented 8 months ago

thanks for this! Just left a comment on improving the message, let me know what you think.

yes, that looks better, but seems you merged it before I could update it

There’s a lot of red in the workflows, I’ll take a look and try to unblock PRs