awslabs / goformation

GoFormation is a Go library for working with CloudFormation templates.
Apache License 2.0
841 stars 197 forks source link

fix(schema): add FunctionResponseTypes property for kinesis events #539

Closed gsweetwood closed 1 year ago

gsweetwood commented 1 year ago

Issue #, if available: Related schema issue in aws-toolkit-vscode: https://github.com/aws/aws-toolkit-vscode/issues/2924

Description of changes: This PR adds the FunctionResponseTypes property for Kinesis events.

The AWS documentation can be found here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-eventsourcemapping.html#cfn-lambda-eventsourcemapping-functionresponsetypes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 1 year ago

Codecov Report

Base: 6.15% // Head: 6.15% // No change to project coverage :thumbsup:

Coverage data is based on head (f531a8e) compared to base (35fa19d). Patch has no changes to coverable lines.

:exclamation: Current head f531a8e differs from pull request most recent head a60fe49. Consider uploading reports for the commit a60fe49 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #539 +/- ## ====================================== Coverage 6.15% 6.15% ====================================== Files 30 30 Lines 16463 16463 ====================================== Hits 1014 1014 Misses 15424 15424 Partials 25 25 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 7.2.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: