awslabs / goformation

GoFormation is a Go library for working with CloudFormation templates.
Apache License 2.0
840 stars 197 forks source link

fix(intrinsics): continue to process children when transforming #599

Closed rubenfonseca closed 1 year ago

rubenfonseca commented 1 year ago

Issue #, if available: #554, #551

Description of changes:

This PR fixes the short form intrinsics processor that would stop processing the children nodes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 62.50% and no project coverage change.

Comparison is base (af3d4b2) 5.79% compared to head (db8fce7) 5.80%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #599 +/- ## ====================================== Coverage 5.79% 5.80% ====================================== Files 30 30 Lines 17594 17599 +5 ====================================== + Hits 1020 1022 +2 - Misses 16546 16548 +2 - Partials 28 29 +1 ``` | [Impacted Files](https://app.codecov.io/gh/awslabs/goformation/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [intrinsics/tags.go](https://app.codecov.io/gh/awslabs/goformation/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-aW50cmluc2ljcy90YWdzLmdv) | `68.25% <62.50%> (-2.44%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 7.8.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: