fix(schema): allow current LogPublishingOptions names

awslabs / goformation

GoFormation is a Go library for working with CloudFormation templates.

Apache License 2.0

841 stars 197 forks source link

fix(schema): allow current LogPublishingOptions names #645

Open yuri1969 opened 5 months ago

yuri1969 commented 5 months ago

Description of changes:

Current LogPublishingOptions names feature _ characters.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-opensearchservice-domain-logpublishingoption.html

rubenfonseca commented 5 months ago

Hi @yuri1969 do you have any other evidence that _ is part of those strings? I cannot find anything on the link you've posted

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (17006b2) 5.34% compared to head (9441407) 5.34%. Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #645 +/- ## ====================================== Coverage 5.34% 5.34% ====================================== Files 30 30 Lines 19111 19111 ====================================== Hits 1022 1022 Misses 18060 18060 Partials 29 29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yuri1969 commented 5 months ago

@rubenfonseca Currently there are SEARCH_SLOW_LOGS, ES_APPLICATION_LOGS, INDEX_SLOW_LOGS, and AUDIT_LOGS names defined. The linked doc also features a link to the OpenSearch CF examples.

See the copied example snippet below:

...
LogPublishingOptions:
      ES_APPLICATION_LOGS:
          CloudWatchLogsLogGroupArn: 'arn:aws:...'
          Enabled: true
...

rubenfonseca commented 5 months ago

Ah got it! The files you've changed are autogenerated from code everytime we do "go generate", so we'll have to find another way to encode this. I'll get back to you.