search

awslabs / graphstorm

Enterprise graph machine learning framework for billion-scale graphs for ML scientists and data scientists.
Apache License 2.0
358 stars 55 forks source link

Naming a module `sagemaker` confuses pylint #881

Closed thvasilo closed 1 month ago

thvasilo commented 2 months ago

Because we include a graphstorm.sagemaker module, we can false positives in pylint such as

************* Module python.graphstorm.sagemaker.sagemaker_partition
[2024-06-17T22:04:35.164Z] python/graphstorm/sagemaker/sagemaker_partition.py:33:0: C0411: third party import "from joblib import Parallel, delayed" should be placed before "import sagemaker" (wrong-import-order)`

We should rename our graphstorm.sagemaker module to something like graphstorm.gs_sagemaker to avoid such issues and ambivalence about whether we are importing the sagemaker lib or local module.

classicsong commented 1 month ago

Can we close it?

thvasilo commented 1 month ago

We can either close as won't fix, or rename the module to something like gsf_sagemaker which should get rid of the error. This should be easy enough to do using an IDE.