fix the code pipeline 'prettier' lint error

awslabs / green-boost

Build Full Stack Cloud Native Web Apps on AWS Fast

https://awslabs.github.io/green-boost/

Apache License 2.0

71 stars 8 forks source link

fix the code pipeline 'prettier' lint error #258

Closed leodDEV closed 11 months ago

leodDEV commented 1 year ago

Issue #, if available: code pipeline build fails this lint error: 17:48 error Replace ⏎······this,·⏎······"CodeCommitRepo",⏎······"appId"⏎···· with this,·"CodeCommitRepo",·"appId" prettier/prettier

✖ 1 problem (1 error, 0 warnings)

Description of changes: fix the pipeline that throws the build error

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: a95eef262b0ee9ec5ce827f1452f6493e450b8f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------ | ----- | | gboost | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

bestickley commented 11 months ago

Hey @leodDEV, thank you very much for this PR. The issue here is the if the user supplies a long appId then your suggested changes will cause a prettier error, but if the appId is short, then the current template will cause a prettier error. To reduce issues, I'm going to put a // eslint-disable-next-line prettier/prettier above this line. I will be adding it in another PR I'm working on now. Thanks, again!