fix: `storage/buckets` Correct issues with bucket names above character limit - Githubissues

awslabs / idf-modules

Industry Data Framework (IDF) IAC modules repository

Apache License 2.0

24 stars 14 forks source link

fix: `storage/buckets` Correct issues with bucket names above character limit #175

Closed malachi-constant closed 4 months ago

malachi-constant commented 4 months ago

fix: storage/buckets Correct issues with bucket names above character limit

Changes

Fixes issue with bucket names larger than 60 characters.
Compartmentalize hashing function to hash only when bucket name is under character limit & trim when over
Formatting
Unit Test for the above

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

malachi-constant commented 4 months ago

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: 82b533d2cd151ae5417635856183505d51d5fdd6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

malachi-constant commented 4 months ago

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: de172434a6c962415ca769d32c5a8f1b9aad2b8c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

malachi-constant commented 4 months ago

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: 13c8386291115a94519ff552db632c0df174959f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

srinivasreddych commented 4 months ago

LGTM. Pls check the test results

malachi-constant commented 4 months ago

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: 00e2fa70285e1a68d4947412009f3f46b2627eca
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

malachi-constant commented 4 months ago

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: ff9932511d42921d6bee3651a14f03966ba6829f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

malachi-constant commented 4 months ago

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: c460cad6070b43cd16514fb7dc7da201cf8e9d50
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

malachi-constant commented 4 months ago

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: a87ac1c568baac2a48215956d027aece26fb3767
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository