chore: refactored docker images replication module

awslabs / idf-modules

Industry Data Framework (IDF) IAC modules repository

Apache License 2.0

25 stars 14 forks source link

chore: refactored docker images replication module #282

Closed srinivasreddych closed 2 months ago

srinivasreddych commented 2 months ago

Issue #, if available:

Description of changes:

fixed the deletion workflow and provided an input to remove the hardcoded idf as project name
refactored the shell script to check the repo first, check the image if exists and push images only if needed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

malachi-constant commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: fbc0c42245c76658aae1beb71fc033903408560c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

malachi-constant commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: a2cc0fc77d05de2f13213c73fce9159f20432ea5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

malachi-constant commented 2 months ago

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: 403c037f028b8130c848ab52a3da288e9e0475a4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

srinivasreddych commented 2 months ago

Looks good, are we now defferring to CONTIRBUTING, LICENSE etc at the root of repo?

And looks like there's some static checks to fix

Fixed the static checks. Also, from my knowledge, we always refer to the license, contributing.md at the root of the repo, right? I've checked the IDF modules and that's what i observed. Do you have any suggestion @malachi-constant ?