awslabs / iot-app-kit

A development library for creating web applications to visualize industrial data
Apache License 2.0
118 stars 61 forks source link

fix(dashboard): remove gap at bottom of chart in juicebox #3042

Closed ssjagad closed 1 month ago

ssjagad commented 1 month ago

Overview

We were seeing this gap at the bottom of the line chart in juicebox. image

Issue is due to react-adding wrapper div around base-chart element in juicebox. image

This is automatically done by React when there is no react fragment wrapping around passed in divs (which is occurring in the table component due to the chart + legend). https://react.dev/reference/react/Fragment

Verifying Changes

This fix was tarballed and tested that it removed the gap in Juicebox. image

Legal

This project is available under the Apache 2.0 License.

ssjagad commented 1 month ago

Better way to do this. Closing branch.