awslabs / keras-apache-mxnet

[DEPRECATED] Amazon Deep Learning's Keras with Apache MXNet support
https://github.com/awslabs/keras-apache-mxnet/wiki
Other
290 stars 65 forks source link

Add saving mxnet model checkpoint callback #132

Closed sandeep-krishnamurthy closed 6 years ago

sandeep-krishnamurthy commented 6 years ago

https://github.com/awslabs/keras-apache-mxnet/issues/130

@roywei @kalyac

sandeep-krishnamurthy commented 6 years ago

@roywei @kalyc - Ready for review.

sandeep-krishnamurthy commented 6 years ago

@kalyc - Thanks for your review. Addressed the comments.

sandeep-krishnamurthy commented 6 years ago

@roywei - Thanks for reviewing. Yes, we can add check in save_mxnet_model API. I would like to do it in separate PR. Also, I would like to introduce filepath option for allowing users to save in their directory of choice.

That is right, keras users are accustomed to pass save_best_only=True when using ModelCheckpointCallback.