awslabs / keras-apache-mxnet

[DEPRECATED] Amazon Deep Learning's Keras with Apache MXNet support
https://github.com/awslabs/keras-apache-mxnet/wiki
Other
290 stars 65 forks source link

Add sparse sum, mean and dot operator support #162

Closed kalyc closed 6 years ago

kalyc commented 6 years ago

Summary

Add sparse support for sum, mean and dot operators

Related Issues

Continuing - https://github.com/awslabs/keras-apache-mxnet/pull/159 Missing sparse operators

PR Overview

kalyc commented 6 years ago

Addressed comments. Testing on benchmark model not yet done.

kalyc commented 6 years ago

Addressed refactoring comments

sandeep-krishnamurthy commented 6 years ago

Thanks. LGTM. Going ahead with merging these operators. Please follow up with an end to end example using sparse tensor (may be think of having this end to end example work for your benchmarking as well)

kalyc commented 6 years ago

Yes will do - we will need to update the existing benchmark script to use these operators as well.