Full RNN support with control flow ops - Githubissues

awslabs / keras-apache-mxnet

[DEPRECATED] Amazon Deep Learning's Keras with Apache MXNet support

https://github.com/awslabs/keras-apache-mxnet/wiki

Other

290 stars 65 forks source link

Full RNN support with control flow ops #168

Closed roywei closed 6 years ago

roywei commented 6 years ago

Summary

Add control flow ops in RNN so we can set unroll=False as default
resolved drop out issue: https://github.com/awslabs/keras-apache-mxnet/issues/60
enabled 18 rnn unit tests

Related Issues

https://github.com/awslabs/keras-apache-mxnet/wiki/Using-RNN-with-MXNet-backend https://github.com/awslabs/keras-apache-mxnet/issues/60

PR Overview

[x] This PR requires new unit tests [y/n] (make sure tests are included)
[x] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[x] This PR is backwards compatible [y/n]
[x] This PR changes the current API [y/n]

kalyc commented 6 years ago

Will this require update in documentation? using_rnn_with_mxnet_backend?

roywei commented 6 years ago

Will this require update in documentation? using_rnn_with_mxnet_backend?

Updated