search

awslabs / keras-apache-mxnet

[DEPRECATED] Amazon Deep Learning's Keras with Apache MXNet support
https://github.com/awslabs/keras-apache-mxnet/wiki
Other
290 stars 65 forks source link

Enable sparse_concat test #179

Closed kalyc closed 6 years ago

kalyc commented 6 years ago

Enable sparse_concat test which was disabled in this PR - https://github.com/awslabs/keras-apache-mxnet/pull/177

This test was failing as there are no bind values in the KerasSymbol and because of this whenever this symbol was evaluated in forward pass, we cannot conclude if its sparse or not. We need a way in which we can check if tensor is sparse by adding an attribute to it (such as stype).

vandanavk commented 6 years ago

Can this be closed? The PR has been merged