awslabs / keras-apache-mxnet

[DEPRECATED] Amazon Deep Learning's Keras with Apache MXNet support
https://github.com/awslabs/keras-apache-mxnet/wiki
Other
289 stars 65 forks source link

fix nightly on sgd #225

Closed roywei closed 5 years ago

roywei commented 5 years ago

Summary

nightly test failed due to an update from MXNet side on SGD optimizer: https://github.com/apache/incubator-mxnet/pull/13346

changed SGD optimizer in mxnet backend accordingly, and set aggregate_num=1, as Keras optimizer do it 1 at a time.

roywei commented 5 years ago

failed tests reduce from 37 to 5, need to fix some other ops impacted.

roywei commented 5 years ago

waiting for the fix on mxnet to go in nightly build

roywei commented 5 years ago

@sandeep-krishnamurthy @karan6181 could you help take a look? Thanks! This will make keras compatible with latest mxnet again.