Stack - Githubissues

awslabs / keras-apache-mxnet

[DEPRECATED] Amazon Deep Learning's Keras with Apache MXNet support

https://github.com/awslabs/keras-apache-mxnet/wiki

Other

290 stars 65 forks source link

Stack #262

Closed pjelement closed 4 years ago

pjelement commented 4 years ago

Summary

Remove redundant code to fix axis issue and update the unit test for stack function

Related Issues

stack method not work correctly when axis set to -1

PR Overview

[ Y ] This PR requires new unit tests [y/n] (make sure tests are included)
[ N ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[ N ] This PR is backwards compatible [y/n]
[ N ] This PR changes the current API [y/n]

roywei commented 4 years ago

Hi @pjelement there are conflict in your PR. Once your previous PR is merged, you need to create a new branch and track the latest upstream/master to include your merged commit. git fetch upstream git checkout -b fix_stack --track upstream/master

roywei commented 4 years ago

closing in favor of #263