awslabs / kinesis-aggregation

AWS libraries/modules for working with Kinesis aggregated record data
Apache License 2.0
376 stars 154 forks source link

Fix node UserRecord typings #125

Closed stevegoossens closed 3 years ago

stevegoossens commented 3 years ago

Issue #, if available:

possibly #48

Description of changes:

Why?

node/lib/kpl-deagg.js uses camelCase for sequenceNumber and subSequenceNumber. Currently, the mismatch means that UserRecord.sequencenumber and UserRecord.subSequencenumber are undefined

The explicitHashKey should be optional, because it is not a required parameter of a PutRecord nor PutRecordRequestEntry. Making it optional in the interface means that expected UserRecord with undefined explicitHashKey can be used in tests and code.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.