search

awslabs / kinesis-aggregation

AWS libraries/modules for working with Kinesis aggregated record data
Apache License 2.0
376 stars 154 forks source link

upgrade dependency aws-sdk-v2 #143

Closed plopezlpz closed 2 years ago

plopezlpz commented 3 years ago

Issue #, if available:

Description of changes:

Upgrade dependency to use aws-sdk-v2

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jpaskhay commented 3 years ago

Nice work on this @plopezlpz! I wonder if it would be preferred to maintain separate v1 and v2 Go modules, similar to the Java implementations? Likely requires breaking/refactoring the current Go module, but it may be cleaner for any users who are bound to v1.

Hey @IanMeyers, is there any chance this PR can get eyes on it soon (and your input on the above)?

I'm preparing a contribution for another open source repo that adds Go deaggregation support, and it already uses aws-sdk-go-v2. It would be really nice to avoid having to introduce the aws-sdk-go (v1) dependency into that repo, if possible.

Thanks!

harlow commented 2 years ago

would be great to have a versioned directory! nice work

fafg commented 2 years ago

There are a couple of libraries it can't upgrade to aws-go-sdk-v2 because of this package. could someone do merge?