Closed andrejleitner closed 2 years ago
There is no reason to have npm defined as dependency. https://github.com/awslabs/kinesis-aggregation/blob/953b66f6740731c9299c714c3be74a49ce2e53fd/node/package.json#L15 If the intention was to set npm version requirement for the project, engines property seems to be more suitable place.
npm
engines
There is no reason to have
npmdefined as dependency. https://github.com/awslabs/kinesis-aggregation/blob/953b66f6740731c9299c714c3be74a49ce2e53fd/node/package.json#L15 If the intention was to setnpmversion requirement for the project,enginesproperty seems to be more suitable place.