search

awslabs / kinesis-aggregation

AWS libraries/modules for working with Kinesis aggregated record data
Apache License 2.0
376 stars 154 forks source link

Documentation mentions using AggregationManager, which does not exist #162

Closed maxispeicher closed 2 years ago

maxispeicher commented 2 years ago

The existing README.md for the python package and the potential_data_loss.md both mention using the AggregationManager from version 1.2.0 onwards. However, this class does not exist in the mentioned versions in the python code at all.

IanMeyers commented 2 years ago

Correct - this documentation was incorrect and has been deleted.

tzcnt commented 2 years ago

Has the underlying issue with the KCL dropping messages not destined for the assigned consumer been fixed? If not, then I think the documentation should have been modified, rather than deleted entirely. It's still linked from the front README with an all caps DATA LOSS CAN OCCUR. This is now a dead link.

It would be very helpful to still have an explanation of the underlying issue, even if there is no workaround.

tzcnt commented 2 years ago

@IanMeyers

IanMeyers commented 2 years ago

Documentation has been restored and corrected.