search

awslabs / kinesis-aggregation

AWS libraries/modules for working with Kinesis aggregated record data
Apache License 2.0
378 stars 154 forks source link

Support for Golang? #55

Open lyphilip opened 6 years ago

lyphilip commented 6 years ago

Is there a plan to add support for golang? we have a use case where we sent mysql binlog data from Maxwell to kinesis, then consume data using aws lambda and everything was built on Go. Now we have to disable the aggregation (which apparently impact the performance)

ghost commented 6 years ago

Thanks for the comment @lyphilip! We would be interested in adding Go support for sure, but I don't think anyone in the group of us who work on the package have used Go before. Let us look into it and try to get back to you.

rayjlinden commented 5 years ago

We would love to see a Golang version as well. Any update on this?

rgarcia commented 5 years ago

As a workaround, we've used the extractRecords method from https://github.com/a8m/kinesis-producer

rayjlinden commented 5 years ago

I found this same thing about 2 days ago. Seems to be working for me (though we will be testing in production this next week.) In fact, it is really messages.pb.go https://github.com/a8m/kinesis-producer/blob/master/messages.pb.go that is needed. Which given, i the end how little code that actually is I find it more ridiculous that this support is not in the aws library.

On Sun, Apr 7, 2019 at 3:55 PM Rafael notifications@github.com wrote:

As a workaround, we've used the extractRecords method from https://github.com/a8m/kinesis-producer

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/awslabs/kinesis-aggregation/issues/55#issuecomment-480637809, or mute the thread https://github.com/notifications/unsubscribe-auth/AonV2iO4kwmbZaqmETY391Vrv397OQMTks5vendegaJpZM4VtSBm .

guyest commented 5 years ago

Would a pull request of some subset of the functionality included in a8m/kinesis-producer or similar be reasonable here to have support for aggregation as well? Symmetric agg/de-agg support in Go would be great even if short of the ideal full KCL/KPL implementation.