Node version of lib includes large dependency jshint

awslabs / kinesis-aggregation

AWS libraries/modules for working with Kinesis aggregated record data

Apache License 2.0

376 stars 154 forks source link

Open TakesTheBiscuit opened 4 years ago

TakesTheBiscuit commented 4 years ago

JSHINT files in the /dist directory were > 2 MB

This meant any lambda functions using this node lib were minimum 2MB without anything else included.

Searched codebase for jshint and found a single reference to it - IMO this is a dev dependency by definition.

IanMeyers commented 4 years ago

Thanks for pointing this out - will try to find some time tomorrow to fix it, or happy to take a PR.

TakesTheBiscuit commented 4 years ago

PR is in already

TakesTheBiscuit commented 4 years ago

Wow, that was fast!

TakesTheBiscuit commented 4 years ago

@IanMeyers were we supposed to bump the package number of the lib itself, sorry may have been an oversight on my part