ISSUE-40 Support for China region - Githubissues

awslabs / kinesis-kafka-connector

kinesis-kafka-connector is connector based on Kafka Connect to publish messages to Amazon Kinesis streams or Amazon Kinesis Firehose.

Apache License 2.0

153 stars 91 forks source link

ISSUE-40 Support for China region #41

Open JoeShi opened 5 years ago

JoeShi commented 5 years ago

Description:

Add option to append line break to each record from Kafka. Add an option appendLineBreak, by enabling this option, the connector will append \n to each record before injecting into Kinesis Datastreams.
Add support for China region. Now if the connector is configured to be used in AWS China region, it will change to the correct Kinesis/Firehose endpoint.

Issue Reference URL

https://github.com/awslabs/kinesis-kafka-connector/issues/40

Do not change content below. Mark applicable check boxes only.

Thank you for submitting a contribution to Kinesis-Kafka Connector.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

[x] Is there a ISSUE associated with this PR?
[x] Does your PR title start with ISSUE-XXXX where XXXX is the issue number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?
[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn clean install at the project's root folder?
[x] Have you written or updated unit tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE file?
[x] If applicable, have you added the LICENSE header to new files?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?