ISSUE-44 Allow a task to run with an IAM role and external-id. - Githubissues

awslabs / kinesis-kafka-connector

kinesis-kafka-connector is connector based on Kafka Connect to publish messages to Amazon Kinesis streams or Amazon Kinesis Firehose.

Apache License 2.0

153 stars 91 forks source link

ISSUE-44 Allow a task to run with an IAM role and external-id. #45

Closed skidder closed 4 years ago

skidder commented 4 years ago

Description:

Allow a Kinesis or Kinesis Firehose task to assume an IAM role with optional external-id. This is especially useful when exporting data from Kafka topics to Kinesis streams owned by another AWS account or organization.

Also, upgrade the Kafka Connect API and AWS dependencies to latest stable.

Issue Reference URL

https://github.com/awslabs/kinesis-kafka-connector/issues/44

Do not change content below. Mark applicable check boxes only.

Thank you for submitting a contribution to Kinesis-Kafka Connector.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

[X] Is there a ISSUE associated with this PR?
[X] Does your PR title start with ISSUE-XXXX where XXXX is the issue number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[X] Has your PR been rebased against the latest commit within the target branch (typically master)?
[X] Is your initial contribution a single, squashed commit?

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn clean install at the project's root folder?
[X] Have you written or updated unit tests to verify your changes?
[X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[X] If applicable, have you updated the LICENSE file?
[X] If applicable, have you added the LICENSE header to new files?

For documentation related changes:

[X] Have you ensured that format looks appropriate for the output in which it is rendered?

skidder commented 4 years ago

@bdesert My apologies for not attaching the correct license. Would you please give it another pass when you have a chance?

skidder commented 4 years ago

@bdesert Please take another pass, I updated the comment as you suggested.

bdesert commented 4 years ago

thanks for contribution! Merged. Closes #44