search

awslabs / kro

kro | Kube Resource Orchestrator
https://kro.run/
Apache License 2.0
184 stars 21 forks source link

Metadata propagation #39

Open nabuskey opened 1 month ago

nabuskey commented 1 month ago

Currently, Symphony does not propagate metadata like custom labels and annotations on a claim to resources. It also does not detect changes to metadata because it looks for generation changes. https://github.com/aws-controllers-k8s/private-symphony/blob/34d870209ee0f575afbae7a9d704583c79e72f78/internal/dynamiccontroller/dynamic_controller.go#L382-L387

This is problematic for a few reasons:

  1. For use cases where user specified labels and annotations are needed. For example, needing to allocate costs by labels and annotations needed by custom controllers.
  2. Using gitops tools like argocd where it relies on labels and annotations to track resources associated with an application. e.g. users cannot see resources associated with claims in the UI.
  3. Object backup becomes difficult. e.g. you can't really use Velero to backup specific resources associated with an app.
nabuskey commented 1 month ago

Ok tested more with main. It does work for ArgoCD visualization since ownerReferences are set now.