awslabs / kubernetes-iteration-toolkit

Apache License 2.0
54 stars 37 forks source link

PVRE reporting for short lived instances #427

Closed smahendarkar closed 11 months ago

smahendarkar commented 1 year ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

hakuna-matatah commented 1 year ago

Have we verified that this template fixes two issues that we have been having ?

smahendarkar commented 1 year ago

I created a launch template running this CFN stack in my dev account. If I can have permissions for perf lab, I can validate if we can create a MNG with this LT which ideally should fix the issues. Not sure if I could validate it further

hakuna-matatah commented 1 year ago

I created a launch template running this CFN stack in my dev account. If I can have permissions for perf lab, I can validate if we can create a MNG with this LT which ideally should fix the issues. Not sure if I could validate it further

I will give you access to perflab, we should verify if this task is running smoothly on experimental infra.

hakuna-matatah commented 12 months ago

Overall nice work @sushimaAws.

hakuna-matatah commented 11 months ago

Do not merge until internal changes are reviewed and merged as it will break current tests.