awslabs / landing-zone-accelerator-on-aws

Deploy a multi-account cloud foundation to support highly-regulated workloads and complex compliance requirements.
https://aws.amazon.com/solutions/implementations/landing-zone-accelerator-on-aws/
Apache License 2.0
535 stars 425 forks source link

Build fails while trying to delete "Default Subnet" from default vpc #212

Closed SatinderSidhu closed 1 year ago

SatinderSidhu commented 1 year ago

Describe the bug 377 | 2023-07-20 02:14:25.258 | error | toolkit | Stack Deployments Failed: Error: The stack named AWSAccelerator-NetworkVpcStack-916366982292-us-west-2 failed to deploy: UPDATE_ROLLBACK_COMPLETE: Received response status [FAILED] from custom resource. Message returned: DependencyViolation: The subnet 'subnet-05ea80822a773ea9f' has dependencies and cannot be deleted.

To Reproduce I am running the following and my build fails with above error. I can not even manually delete the subnet, https://github.com/awslabs/landing-zone-accelerator-on-aws/tree/main/reference/sample-configurations/aws-best-practices-healthcare

Expected behavior Either of following

  1. This code is creating its own vpc, it should not have any dependency on default vpc

Please complete the following information about the solution:

To get the version of the solution, you can look at the description of the created CloudFormation stack. For example, "(SO0021) - Video On Demand workflow with AWS Step Functions, MediaConvert, MediaPackage, S3, CloudFront and DynamoDB. Version v5.0.0". If the description does not contain the version information, you can look at the mappings section of the template:

Mappings:
  SourceCode:
    General:
      S3Bucket: "solutions"
      KeyPrefix: "video-on-demand-on-aws/v5.0.0"

Screenshots If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information). image

Additional context Add any other context about the problem here.

SatinderSidhu commented 1 year ago

This issue is fixed as I had some additional resources holding up removal of VPC