awslabs / landing-zone-accelerator-on-aws

Deploy a multi-account cloud foundation to support highly-regulated workloads and complex compliance requirements.
https://aws.amazon.com/solutions/implementations/landing-zone-accelerator-on-aws/
Apache License 2.0
565 stars 453 forks source link

Upgrade BucketReplicationProps interface to use V2 schema #376

Open StephenBedard opened 10 months ago

StephenBedard commented 10 months ago

Is your feature request related to a problem? Please describe. If I try to programmatically add a replication rule to the ELB access logs bucket created within the log archive account, this error is thrown: An error occurred (InvalidRequest) when calling the PutBucketReplication operation: Number of distinct destination bucket ARNs cannot exceed 1

This appears to be due to the BucketReplicationProps interface enforcing the V1 schema of the replication configuration. The primary difference between V1 and V2 being that Prefix is replaced by Filter in V2 and that V2 supports RTC.

Describe the feature you'd like It'd be nice to convert this schema to V2 so it's supportive of use cases where someone needs to replicate their bucket's contents to more than one destination bucket.

Additional context I'd be more than happy to implement this if accepted! :smiley:

bo1984 commented 10 months ago

Thank you for reaching out, @StephenBedard and for utilizing the Landing Zone Accelerator on AWS solution. I've gone ahead and filed a feature request for this issue. Should you have any questions or concerns in the meantime, I will keep this issue open for further communication and update you on the status of this issue. Also, as a temporary workaround, you can make use of the customizations layer to set up the replicate rules to multiple S3 destination buckets for the ELB Bucket.