awslabs / landing-zone-accelerator-on-aws

Deploy a multi-account cloud foundation to support highly-regulated workloads and complex compliance requirements.
https://aws.amazon.com/solutions/implementations/landing-zone-accelerator-on-aws/
Apache License 2.0
531 stars 420 forks source link

Tags are not created in some resources when the global tags are enabled #415

Open xp-versent opened 6 months ago

xp-versent commented 6 months ago

Is your feature request related to a problem? Please describe. We defined tags [] in the global-config.yaml file as tags:

richardkeit commented 6 months ago

AWS Team - this is a bug and not an enhancement based on the definition in GlobalConfigTags:

Custom Tags for all resources created by Landing Zone Accelerator that can be tagged.

Describe the bug Using the global tags, not all resources that support tags are tagged with specified values

To Reproduce Example config: global-config:

tags:
- key: "bus:cost-centre"
  value: "12345"
- key: "bus:application-name"
  value: "xyz-aws-lza"

Expected behavior All resources

bo1984 commented 4 months ago

Hello, we have an open bug report for the VPC Endpoints and Subnets not applying the global tags. So you're aware, the DNS resolver endpoints have an exception to not apply the tags as you can see that logic here

schnipseljagd commented 2 months ago

Also the tags are not applied to different AWSAccelerator- Cloudformation stacks.