awslabs / landing-zone-accelerator-on-aws

Deploy a multi-account cloud foundation to support highly-regulated workloads and complex compliance requirements.
https://aws.amazon.com/solutions/implementations/landing-zone-accelerator-on-aws/
Apache License 2.0
527 stars 416 forks source link

ORG_ID policy replacement variable for Customizations #429

Open teddevaal opened 4 months ago

teddevaal commented 4 months ago

Describe the feature you'd like When deploying a CloudFormationStackConfig Customization, I would like to have the ability to define ACCEL_LOOKUP variables as part of the configuration.

Additional context

customizations:
  cloudFormationStacks:
    - deploymentTargets:
        organizationalUnits:
          - Root
      description: Creates a Custom CloudFormation stack
      name: AWSAccelerator-Customization-Stack
      regions:
        - *HOME_REGION
      runOrder: 1
      template: customizations/cfn-templates/cfn-template.yaml
      parameters:
        - name: Frequency
          value: '24hours'
        - name: OrganisationId
          value: '${ORG_ID}'

https://docs.aws.amazon.com/solutions/latest/landing-zone-accelerator-on-aws/working-with-solution-specific-variables.html#policy-replacement-variables

joshuahigginson1 commented 4 months ago

This is a +1 from me. Currently, we have a convoluted customization which achieves this for us

richardkeit commented 4 months ago

This is a +1 from me. Currently, we have a convoluted customization which achieves this for us

For us also @joshuahigginson1

Exposing the ACCEL_LOOKUP values would dramatically simplify day 2 operations for a lot of people

erwaxler commented 4 months ago

Hi @teddevaal , , thank you for filing a feature request with the Landing Zone Accelerator team! Our team will evaluate the applicability of this request for a future release, this seems like a straightforward implementation that would help a lot of users.

We will keep this issue open for tracking purposes and keep you aware of any status updates going forward. Thank you for supporting Landing Zone Accelerator!

richardkeit commented 3 months ago

Hi @erwaxler ,

Another common use case is for IAM policies for KMS actions, referring to the central KMS key (for session manager)