awslabs / landing-zone-accelerator-on-aws

Deploy a multi-account cloud foundation to support highly-regulated workloads and complex compliance requirements.
https://aws.amazon.com/solutions/implementations/landing-zone-accelerator-on-aws/
Apache License 2.0
565 stars 453 forks source link

Add support to tag network interfaces #485

Open senyberg opened 5 months ago

senyberg commented 5 months ago

Is your feature request related to a problem? Please describe. Currently you cannot tag Network Interfaces from LZA. With a shared network, where you would like to limit access to Workload accounts using policies, this is an issue.

Describe the feature you'd like Add a "tags" property to network interfaces for TGW attachments (interface type: transit_gateway)

bo1984 commented 5 months ago

Hi Sebastian,

Thank you for contacting us and using the Landing Zone Accelerator on AWS (LZA) solution. I'd like to dig into your use case deeper to hopefully provide a better resolution and possibly an alternative path. What access are you trying to prevent? Also, our customizations layer will allow you to provision your own CloudFormation templates where you can have a custom resource add the tags to the ENI of the attachment.

senyberg commented 5 months ago

So this is shortly how our setup looks like:

We want to stop the 3rd party vendors to touch the TGW Attachment ENI's, so basically deny all on resource. I have not found a way to do this reliably without the using tags. And yes, you could create a CF template with custom resources, but this is a lot more work and things to maintain, just for tags on an ENI.